llvm-lto2: Add print-guid subcommand. #143992
Conversation
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1 [skip ci]
Created using spr 1.3.6-beta.1
teresajohnson
left a comment
teresajohnson
left a comment
There was a problem hiding this comment.
This needs a caveat somewhere (either in printed usage message or in a comment) that this won't work for local linkage symbols (I suppose the user could give the "file:" prefix but that won't work if -funique-internal-linkage-names was specified etc). Can you also add a test?
Created using spr 1.3.6-beta.1 [skip ci]
Created using spr 1.3.6-beta.1
I'm not sure that is worth it. The intent is that users of these development tools will refer to the source code. And if you read the source code you'll see the function name
Done. |
At least a comment in the code would be good. A variety of people end up using these tools for tests, and I could see someone getting confused as to why the guid doesn't match what's e.g. in the ThinLTO index. For that understanding you'd have to read more than just what this source file is calling. |
Created using spr 1.3.6-beta.1
I added a comment. |
pcc
changed the base branch from
users/pcc/spr/main.llvm-lto2-add-print-guid-subcommand
to
main
This is useful for debugging ThinLTO issues. Reviewers: teresajohnson Reviewed By: teresajohnson Pull Request: llvm/llvm-project#143992
This is useful for debugging ThinLTO issues. Reviewers: teresajohnson Reviewed By: teresajohnson Pull Request: llvm#143992
This is useful for debugging ThinLTO issues. Reviewers: teresajohnson Reviewed By: teresajohnson Pull Request: llvm#143992
This is useful for debugging ThinLTO issues.